Implement 3 part MSRV policy#8999
Merged
cwfitzgerald merged 1 commit intogfx-rs:trunkfrom Feb 8, 2026
Merged
Conversation
202b4d9 to
dee7633
Compare
Collaborator
inner-daemons
left a comment
There was a problem hiding this comment.
I have some unimportant questions
| Due to complex dependants, we have three MSRV policies: | ||
|
|
||
| - `naga`, `wgpu-core`, `wgpu-hal`, and `wgpu-types`'s MSRV is **1.90**. | ||
| - `wgpu`'s MSRV is **1.87** |
Collaborator
There was a problem hiding this comment.
wgpu is a light crate, I don't think it would ever need a higher MSRV than core?
Member
Author
There was a problem hiding this comment.
There is still quite a bit of machinery in it, so we might want to bump it for various rust utilities.
Collaborator
There was a problem hiding this comment.
I would opine that this wouldn't justify the complexity but I think that discussion has already been had.
Member
Author
There was a problem hiding this comment.
It's not really that much complexity, just an extra set of CI checks, essentially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Closes #8971
Description
This implements the plan laid out in #8971 (comment) and implements enforcement for it
Testing
CI.