Improve validation in B2B copies and RenderCommands#895
Merged
bors[bot] merged 2 commits intogfx-rs:masterfrom Aug 24, 2020
Merged
Improve validation in B2B copies and RenderCommands#895bors[bot] merged 2 commits intogfx-rs:masterfrom
bors[bot] merged 2 commits intogfx-rs:masterfrom
Conversation
Contributor
Author
|
I am not sure when |
Member
|
We don't have the occlusion queries implemented yet, so the |
kvark
approved these changes
Aug 24, 2020
Member
kvark
left a comment
There was a problem hiding this comment.
Very nice, thank you!
Just a couple of small suggestions here
Member
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Validation for the following have been added-
copy_size == 0.RenderPass.setViewport()RenderPass.setScissorRect()Testing
Explain how this change is tested.
Tested with CTS in Servo. More tests pass now. Will test on wgpu-rs now.