Fix constant evaluation of sign(0.0f)#8942
Merged
andyleiserson merged 4 commits intogfx-rs:trunkfrom Jan 27, 2026
Merged
Conversation
5a601b0 to
abe52f4
Compare
80 tasks
andyleiserson
approved these changes
Jan 27, 2026
Contributor
andyleiserson
left a comment
There was a problem hiding this comment.
Thanks!
I checked the CTS, and it does have coverage for this, in webgpu:shader,execution,expression,call,builtin,sign:*, but there are also still some failures in that test due to not having constant evaluation for frexp, so we can rely on the snapshot test for now.
Negative zero is also an interesting test case, which the CTS covers, so I don't think it's necessary to add it to the snapshot test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to WGSL spec, sign(0) = 0
In
constant_evaluator.rsthesignummethod is used to evaluate sign(e).However,
0_f32.signum()andf16::ZERO.signum()output 1.0f, not 0.0f.https://doc.rust-lang.org/std/primitive.f32.html#method.signum
https://docs.rs/half/latest/half/struct.f16.html#method.signum
Because of this, the following shader outputs 1.0f:
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.