[0.6] Backport buffer and texture overrun error messages#886
Merged
bors[bot] merged 1 commit intogfx-rs:v0.6from Aug 19, 2020
Merged
[0.6] Backport buffer and texture overrun error messages#886bors[bot] merged 1 commit intogfx-rs:v0.6from
bors[bot] merged 1 commit intogfx-rs:v0.6from
Conversation
kvark
approved these changes
Aug 19, 2020
Member
kvark
left a comment
There was a problem hiding this comment.
bors r+
(we aren't going to publish a patch just for that, it will come with the next patch)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
#885 but neutered to be a non-breaking change.
Description
The original error message talked only about the destination buffer, which is very confusing as the cause of the overrun could be the source buffer.
Not worth a release on its own, but next time there's a release, we can get this fixed.
Testing
Strings only.