Custom implement Debug for RenderCommand and ComputeCommand#747
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Jun 24, 2020
Merged
Custom implement Debug for RenderCommand and ComputeCommand#747bors[bot] merged 1 commit intogfx-rs:masterfrom
bors[bot] merged 1 commit intogfx-rs:masterfrom
Conversation
Contributor
Author
|
@kvark I hope this works 😅 . |
kvark
reviewed
Jun 24, 2020
Member
kvark
left a comment
There was a problem hiding this comment.
Last iteration is needed, plus please squash
Contributor
Author
|
Done! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would avoid unnecessarily long debug logs for Render and Compute passes to some extent. I am not sure if it would be helpful to print
dynamic_offsetsandstring_dataunderBasePasswithout the content of relatedCompute/Render Command.