Support DXR in wgpu-hal & naga.#6777
Merged
cwfitzgerald merged 59 commits intogfx-rs:trunkfrom Jan 15, 2025
Merged
Conversation
…tracing # Conflicts: # naga/src/back/hlsl/writer.rs # wgpu-hal/src/dx12/device.rs
…RUCTURE` as we don't yet support enhanced barriers for acceleration structures
Member
|
Same, my 7800xtx passes all tests |
Member
cwfitzgerald
requested changes
Dec 23, 2024
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Super cool to see! Lots of comments, but nothing show stopping!
MarijnS95
reviewed
Dec 27, 2024
cwfitzgerald
requested changes
Jan 8, 2025
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Code transforms look solid, some final nits
cwfitzgerald
approved these changes
Jan 15, 2025
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
I'm going to cautiously accept this on behalf of both wgpu and naga.
Thanks for the work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Might provide alternatives for #6727?
Description
This adds support for DXR in wgpu-hal. Also removes an unnecessary feature requirement from ray_cube_compute as this was preventing it from running on DX12. Also adds support for HLSL raytracing because naga didn't have that either.
Testing
this only extends feature support to dx12 so all previous rt tests work.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.