Use Static-DXC for Tests Locally#6730
Merged
cwfitzgerald merged 1 commit intogfx-rs:trunkfrom Dec 16, 2024
Merged
Conversation
Member
|
I think that as long as we support FXC we should test it as well; especially that it's more constrained than DXC. |
Member
Author
|
That's fine, but it probably needs to be by some other mechanism in the tests. The current state of affairs is that dxc is run in CI (so that raytracing and other advanced features can actually run) so this just makes this match it so local results are consistent with CI. If we want to either change the default or enable a mechanism for testing with fxc as well, that's fine, but orthogonal. |
Member
|
Ah, I see - I missed the fact that CI doesn't already test with FXC. |
teoxoy
approved these changes
Dec 16, 2024
Member
Author
|
Filed #6754 |
This was referenced Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6558