Skip to content

WGSL: add base support for requires that reports nice errors#6437

Merged
ErichDonGubler merged 2 commits intogfx-rs:trunkfrom
erichdongubler-mozilla:erichdongubler/push-nxmwmormowll
Oct 23, 2024
Merged

WGSL: add base support for requires that reports nice errors#6437
ErichDonGubler merged 2 commits intogfx-rs:trunkfrom
erichdongubler-mozilla:erichdongubler/push-nxmwmormowll

Conversation

@ErichDonGubler
Copy link
Copy Markdown
Member

@ErichDonGubler ErichDonGubler commented Oct 22, 2024 •
edited
Loading

Connections

Description

-

Testing

  • I've manually tested this to my satisfaction.
  • Tests will be added in a follow-up PR for the most impactful coverage. Exhaustive coverage is left for WebGPU CTS.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler self-assigned this Oct 22, 2024
@ErichDonGubler ErichDonGubler added type: enhancement New feature or request naga Shader Translator lang: WGSL WebGPU Shading Language labels Oct 22, 2024
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-nxmwmormowll branch 2 times, most recently from c029a21 to 499bddd Compare October 22, 2024 20:18
@ErichDonGubler ErichDonGubler mentioned this pull request Oct 22, 2024
Closed
7 tasks
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-nxmwmormowll branch from 499bddd to 1ccc449 Compare October 22, 2024 21:15
@ErichDonGubler ErichDonGubler mentioned this pull request Oct 22, 2024
Closed
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-nxmwmormowll branch from 1ccc449 to 3513f47 Compare October 22, 2024 21:32
@ErichDonGubler ErichDonGubler changed the title WGSL: Parse requires directives WGSL: Add a skeleton for requires that reports nice errors Oct 22, 2024
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-nxmwmormowll branch from 3513f47 to f0e6893 Compare October 22, 2024 21:53
@ErichDonGubler ErichDonGubler changed the title WGSL: Add a skeleton for requires that reports nice errors WGSL: add base support for requires that reports nice errors Oct 22, 2024
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-nxmwmormowll branch from f0e6893 to c1fe4ca Compare October 23, 2024 02:14
@ErichDonGubler ErichDonGubler marked this pull request as ready for review October 23, 2024 02:14
@ErichDonGubler ErichDonGubler requested a review from a team October 23, 2024 02:14
teoxoy
teoxoy approved these changes Oct 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ErichDonGubler ErichDonGubler merged commit 9730843 into gfx-rs:trunk Oct 23, 2024
@ErichDonGubler ErichDonGubler deleted the erichdongubler/push-nxmwmormowll branch October 23, 2024 15:01
@sagudev sagudev mentioned this pull request Dec 23, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels

lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request

Projects

WebGPU for Firefox
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WGSL: Support the requires directive

2 participants

@ErichDonGubler @teoxoy