Unbreak rustfmt in some places#6349
Merged
ErichDonGubler merged 4 commits intogfx-rs:trunkfrom Oct 3, 2024
Merged
Conversation
6 tasks
ErichDonGubler
commented
Oct 1, 2024
7dd8176 to
965dc6c
Compare
rustfmt on too-long linesrustfmt in some places
07060f6 to
a6ae1a1
Compare
jimblandy
reviewed
Oct 1, 2024
11 tasks
a6ae1a1 to
2d2895e
Compare
Member
Author
|
@jimblandy: Approval plz? |
jimblandy
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Discovered during #6148.
Description
Hunks of Rust source from #6316 and prior have some lines with string literals that are so long that
rustfmtrefuses to reformat both the literal and surrounding runs of expressions. Fix this, and keep chugging with deliciousrustfmt'd code.Testing
Still green in CI, still good!
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toDefinitely not necessary.CHANGELOG.md. See simple instructions inside file.