[naga] Use checked_mul or leading_zeros to detect shl overflows#6186
Merged
teoxoy merged 1 commit intogfx-rs:trunkfrom Aug 31, 2024
Merged
[naga] Use checked_mul or leading_zeros to detect shl overflows#6186teoxoy merged 1 commit intogfx-rs:trunkfrom
teoxoy merged 1 commit intogfx-rs:trunkfrom
Conversation
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
teoxoy
approved these changes
Aug 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
fixes #6175
Description
On u32 we can use
a.checked_mul(1.checked_shl(b)?)?to detect overflows, but unfortunetly same trick does not work for signed numbers, where we simply follow spec per letter.Testing
Tested via CTS run in servo, makes all subtests of
_webgpu/webgpu/cts.https.html?q=webgpu:shader,validation,expression,binary,bitwise_shift:shift_left_concrete:*pass in servoChecklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.