Skip to content

Reduce the number of iterations in benchmarks to a small number when …#6030

Merged
teoxoy merged 1 commit intogfx-rs:trunkfrom
nical:bench-ci
Jul 24, 2024
Merged

Reduce the number of iterations in benchmarks to a small number when …#6030
teoxoy merged 1 commit intogfx-rs:trunkfrom
nical:bench-ci

Conversation

@nical
Copy link
Copy Markdown
Contributor

@nical nical commented Jul 24, 2024

Connections

#6021

Description

We want to run the benchmarks with a very small number of iterations on CI (not to get meaningful numbers out of it but to ensure they don't break). This is done by checking whether the "WGPU_TESTING" environment variable is set.

Checklist

  • Run cargo fmt.
  • Run cargo clippy.
  • Run cargo xtask test to run tests.

@nical nical requested a review from a team as a code owner July 24, 2024 11:48
@teoxoy
Copy link
Copy Markdown
Member

teoxoy commented Jul 24, 2024

Could you do this for DISPATCH_COUNT & DISPATCH_COUNT_BINDLESS as well? DISPATCH_COUNT was the problematic one on macOS (#6021 (comment)).

@nical
Copy link
Copy Markdown
Contributor Author

nical commented Jul 24, 2024

ah yes of course 🤦

Copy link
Copy Markdown
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teoxoy teoxoy merged commit 86507f3 into gfx-rs:trunk Jul 24, 2024
@nical nical deleted the bench-ci branch July 24, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants