Conversation
|
@atlv24 Earlier today you asked me for a suggestion about the texture usages, and a review of the tests. I've posted those now. Is there anything else you need before breaking this up into independent commits for review? |
|
@jimblandy I've broken it into independent commits already, thanks for the feedback. I've implemented the texture usage stuff, now im working on the tests. :D |
ace6c83 to
ceca097
Compare
cwfitzgerald
left a comment
There was a problem hiding this comment.
Looking at the wgpu side:
What would prevent you from doing atomics on an image without the image atomics flag set?
The naga validator currently only permits image atomic operations on the r64uint texture format, and only when the feature is available. No provisions were made for other texture formats yet |
3220089 to
52960d9
Compare
|
@cwfitzgerald i have split this into two PRs: #6706 adds image atomics without any of the 64 bit stuff, this one adds the 64 bit stuff. Only the second commit on this PR is relevant to it, as this PR's branch is based off of the other's, so it includes its commits. |
7cf8199 to
17a304c
Compare
|
Demoting to draft while dependent |
|
Ran this locally, got this failure on all devices This does not appear in CI as image atomics is not supported on any device, in part because of #6911 |
cwfitzgerald
left a comment
There was a problem hiding this comment.
Seems alright to me!
Whatever you did fixed the problem locally
Connections
Fixes #5009
Depends on #6706
Ultimately for bevy meshlets pipeline bevyengine/bevy#10164
Description
Adds 64 bit image atomics to Vulkan, DirectX, and Metal backends. Emulates using RG32Uint on platforms where R64Uint is not available (directX, metal).
Testing
naga tests and runtime tests are included
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.