[naga] Permit override expressions as LocalVariable initializers.#5495
Merged
jimblandy merged 1 commit intogfx-rs:pipeline-constantsfrom Apr 5, 2024
Merged
Conversation
faa15de to
e546125
Compare
teoxoy
reviewed
Apr 5, 2024
teoxoy
approved these changes
Apr 5, 2024
Allow `LocalVariable::init` to be an override expression. Note that this is unrelated to WGSL compliance. The WGSL front end already accepts any sort of expression as an initializer for `LocalVariable`s, but initialization by an override expression was handled in the same way as initialization by a runtime expression, via an explicit `Store` statement. This commit merely lets us skip the `Store` when the initializer is an override expression, producing slightly cleaner output in some cases.
d7f8d0c to
417a380
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
LocalVariable::initto be an override expression.Note that this is unrelated to WGSL compliance. The WGSL front end already accepts any sort of expression as an initializer for
LocalVariables, but initialization by an override expression was handled in the same way as initialization by a runtime expression, via an explicitStorestatement.This commit merely lets us skip the
Storewhen the initializer is an override expression, producing slightly cleaner output in some cases.Resolves #5439.