Implement override-expression evaluation#5249
Merged
jimblandy merged 15 commits intogfx-rs:pipeline-constantsfrom Mar 13, 2024
Merged
Implement override-expression evaluation#5249jimblandy merged 15 commits intogfx-rs:pipeline-constantsfrom
jimblandy merged 15 commits intogfx-rs:pipeline-constantsfrom
Conversation
9e42d3a to
4ac98ea
Compare
jimblandy
requested changes
Mar 5, 2024
Member
jimblandy
left a comment
There was a problem hiding this comment.
Still reviewing, but I found one thing that (I think?) needs to change.
…verride declarations
…verride declarations
Member
|
@teoxoy I pushed some comments - could you see if they're correct? |
Member
Author
|
They look great, thank you! |
jimblandy
approved these changes
Mar 13, 2024
Member
jimblandy
left a comment
There was a problem hiding this comment.
Okay, this looks good, let's merge it.
Member
|
FTR: CI was failing because of #5341, but that's 👌🏻 okay, already been fixed because it was merged. |
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly implements override-expression evaluation for initializers of override declarations.
Tracking meta issue: #4484.