add pipeline constants plumbing#4730
Merged
teoxoy merged 1 commit intogfx-rs:pipeline-constantsfrom Nov 21, 2023
Merged
Conversation
44e86e7 to
a05e269
Compare
nical
approved these changes
Nov 20, 2023
ErichDonGubler
approved these changes
Nov 20, 2023
Member
ErichDonGubler
left a comment
There was a problem hiding this comment.
Bringing in my approval from #4683.
Member
|
FTR: @crowlKats has previously approved this at #4683 (review). |
Member
|
Tests in a future MR pretty please 👉🏻👈🏻 |
jimblandy
approved these changes
Nov 20, 2023
Member
jimblandy
left a comment
There was a problem hiding this comment.
Looks good! Some minor suggestions.
a05e269 to
f46258e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pipeline constants plumbing to the
pipeline-constantsfeature branch.Tracking meta issue: #4484.
Take 3 (#4677, #4683).