Vulkan API version refactors#4252
Merged
cwfitzgerald merged 3 commits intogfx-rs:trunkfrom Oct 17, 2023
Merged
Conversation
fix remaining usages of `instance_api_version` instead of `device_api_version`
Closed
1 task
cwfitzgerald
approved these changes
Oct 17, 2023
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Very nice! VK init continues to be a total cluster 😆
Member
|
Ack, squashed by accident, sorry :) |
Member
Author
|
np, the PR wasn't terribly big |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VK_HEADER_VERSION_COMPLETEwhich is not recommended for this usecaseRelevant links:
https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkEnumerateInstanceVersion.html
https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkPhysicalDeviceProperties.html
https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkApplicationInfo.html
Commits are self-contained and shouldn't need to be squashed.