Implement depth-clip-control using depthClamp#3892
Merged
cwfitzgerald merged 1 commit intogfx-rs:trunkfrom Jun 29, 2023
Merged
Conversation
Use depthClamp instead of VK_EXT_depth_clip_enable to implement depth-clip-control (unclipped_depth). depthClamp implicitly disables clipping and is more widely supported.
a384de3 to
bec1264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Description
In Vulkan, use depthClamp instead of VK_EXT_depth_clip_enable to implement depth-clip-control (unclipped_depth). depthClamp implicitly disables clipping in addition to enabling clamping (27.4. Primitive Clipping in Vulkan spec). Enabling clamping is fine as clamping depth should always be done according to WebGPU spec (23.3.6. Fragment Processing).
depthClamp is more widely supported than VK_EXT_depth_clip_enable (85.94% vs. 38.42% according to vulkan.gpuinfo.org) so this enables depth-clip-control on more devices.
Testing
Ran shadow example.
Ran DepthClamping unit test in https://github.com/Chainsawkitten/HymnToBeauty/ (requires gfx-rs/wgpu-native#270).