Skip to content

GPU Test Framework#3873

Merged
cwfitzgerald merged 49 commits intogfx-rs:trunkfrom
cwfitzgerald:test-framework
Oct 19, 2023
Merged

GPU Test Framework#3873
cwfitzgerald merged 49 commits intogfx-rs:trunkfrom
cwfitzgerald:test-framework

Conversation

@cwfitzgerald
Copy link
Copy Markdown
Member

@cwfitzgerald cwfitzgerald commented Jun 16, 2023 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Closes #3680
Closes #3622
Closes #4097

Description

This revamps our testing framework in multiple different ways.

  • We now automatically test against all adapters in a given system.
  • Supports async and sync code in our tests.
  • Improves the visibility to skipped tests.

How to Review

While there are a ton of changes in this MR, a lot of it is very boring structural changes in the code. Please focus on tests/src examples/common, wgpu-macros and xtask.

Testing

It is lol

@cwfitzgerald cwfitzgerald changed the title Begin with a proper CLI GPU Test Framework Jun 16, 2023
@cwfitzgerald
Copy link
Copy Markdown
Member Author

cwfitzgerald commented Sep 14, 2023

Hey me! Rebase this!

@cwfitzgerald cwfitzgerald mentioned this pull request Sep 15, 2023
Closed
@teoxoy teoxoy mentioned this pull request Sep 21, 2023
Closed
3 tasks
cwfitzgerald
cwfitzgerald commented Sep 28, 2023
View reviewed changes
cwfitzgerald
cwfitzgerald commented Sep 28, 2023
View reviewed changes
@cwfitzgerald cwfitzgerald mentioned this pull request Oct 3, 2023
Merged
@cwfitzgerald cwfitzgerald marked this pull request as ready for review October 12, 2023 04:13
@cwfitzgerald cwfitzgerald requested a review from a team as a code owner October 12, 2023 04:13
@nical

This comment was marked as resolved.

Sign in to view
@nical

This comment was marked as resolved.

Sign in to view
This was referenced Oct 14, 2023
Closed
Open
@cwfitzgerald
Copy link
Copy Markdown
Member Author

cwfitzgerald commented Oct 14, 2023

Alright, I think this MR is finally good to land whenever anyone can find time to review it - thankfully it's not actually as large as it seems:

git diff origin/trunk --stat tests/src examples/common wgpu-macros xtask

is

16 files changed, 1280 insertions(+), 782 deletions(-)

@cwfitzgerald cwfitzgerald mentioned this pull request Oct 18, 2023
Merged
@cwfitzgerald cwfitzgerald mentioned this pull request Oct 19, 2023
Merged
3 tasks
teoxoy
teoxoy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a brief look, nothing looks off.

The new features look great!
Even automatic retry and reporting of flaky tests! 🎉

Shippit! 🚀

@cwfitzgerald
Copy link
Copy Markdown
Member Author

cwfitzgerald commented Oct 19, 2023

WOOOOOOOOO

@cwfitzgerald cwfitzgerald merged commit 543f921 into gfx-rs:trunk Oct 19, 2023
@cwfitzgerald cwfitzgerald deleted the test-framework branch October 19, 2023 16:06
@teoxoy teoxoy mentioned this pull request Jul 16, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Examples which exclude lavapipe wrongly exclude other drivers with mesa vendor id Hard to Tell if Test is Skipped Reconsider lavapipe

3 participants

@cwfitzgerald @nical @teoxoy