Skip to content

Document and improve extension detection#3327

Merged
teoxoy merged 5 commits intogfx-rs:masterfrom
teoxoy:improve-extensions
Jan 5, 2023
Merged

Document and improve extension detection#3327
teoxoy merged 5 commits intogfx-rs:masterfrom
teoxoy:improve-extensions

Conversation

@teoxoy
Copy link
Copy Markdown
Member

@teoxoy teoxoy commented Dec 22, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Description
We used to require VK_EXT_sampler_filter_minmax and never used it.
We used to require VK_KHR_maintenance2 and VK_KHR_timeline_semaphore unconditionally.
We never required VK_EXT_image_robustness and VK_EXT_robustness2 (if available).
We weren't building PhysicalDeviceDescriptorIndexingFeaturesEXT for Vulkan 1.2+.
We weren't building GetPhysicalDeviceProperties2 for Vulkan 1.0, this in turn making some features unusable.

Testing

@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Dec 22, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 22, 2022 •
edited
Loading

Codecov Report

Merging #3327 (e54ae89) into master (aa46e82) will increase coverage by 0.99%.
The diff coverage is 47.88%.

❗ Current head e54ae89 differs from pull request most recent head 1e966d8. Consider uploading reports for the commit 1e966d8 to get more accurate results

@@            Coverage Diff             @@
##           master    #3327      +/-   ##
==========================================
+ Coverage   64.10%   65.09%   +0.99%     
==========================================
  Files          86       86              
  Lines       42591    42874     +283     
==========================================
+ Hits        27301    27910     +609     
+ Misses      15290    14964     -326
Impacted Files Coverage Δ
wgpu-hal/src/vulkan/adapter.rs 78.49% <36.53%> (+2.05%) ⬆️
wgpu-hal/src/vulkan/instance.rs 38.40% <78.94%> (+0.80%) ⬆️
wgpu-core/src/hub.rs 60.67% <0.00%> (-0.31%) ⬇️
wgpu-hal/src/dx12/mod.rs 27.27% <0.00%> (ø)
wgpu-hal/src/vulkan/mod.rs 56.37% <0.00%> (ø)
wgpu-hal/src/dx12/command.rs 73.46% <0.00%> (+0.02%) ⬆️
wgpu-core/src/device/mod.rs 66.82% <0.00%> (+0.09%) ⬆️
wgpu-core/src/validation.rs 59.01% <0.00%> (+0.13%) ⬆️
wgpu-hal/src/auxil/dxgi/conv.rs 76.02% <0.00%> (+0.33%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cwfitzgerald
cwfitzgerald reviewed Dec 26, 2022
View reviewed changes
cwfitzgerald
cwfitzgerald approved these changes Jan 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine - g2g after nit

teoxoy
teoxoy commented Jan 5, 2023
View reviewed changes
@teoxoy teoxoy enabled auto-merge (squash) January 5, 2023 10:06
@teoxoy teoxoy merged commit 39f6b03 into gfx-rs:master Jan 5, 2023
@teoxoy teoxoy deleted the improve-extensions branch January 5, 2023 10:21
@TheoDulka TheoDulka mentioned this pull request Oct 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

WebGPU Specification V1

Development

Successfully merging this pull request may close these issues.

3 participants

@teoxoy @codecov-commenter @cwfitzgerald