Implement SHADER_PRIMITIVE_INDEX on all Backends#3272
Merged
cwfitzgerald merged 3 commits intogfx-rs:masterfrom Dec 8, 2022
Merged
Implement SHADER_PRIMITIVE_INDEX on all Backends#3272cwfitzgerald merged 3 commits intogfx-rs:masterfrom
cwfitzgerald merged 3 commits intogfx-rs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3272 +/- ##
===========================================
+ Coverage 0 64.97% +64.97%
===========================================
Files 0 82 +82
Lines 0 39480 +39480
===========================================
+ Hits 0 25654 +25654
- Misses 0 13826 +13826
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
teoxoy
approved these changes
Dec 8, 2022
Member
teoxoy
left a comment
There was a problem hiding this comment.
I checked the specs and this looks good!
Seems we were missing checks in naga for glsl (filed https://github.com/gfx-rs/naga/issues/2163).
We are also missing version checks for msl but we don't have knowledge of the platform in naga (whether it's Metal for MacOS or iOS). filed https://github.com/gfx-rs/naga/issues/2164
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Closes #3269
Description
Enables SHADER_PRIMITIVE_INDEX where applicable.
Testing
Tested locally using the shader-primitive-index test