Skip to content

Update present_with_transaction#3111

Closed
xiaopengli89 wants to merge 1 commit intogfx-rs:masterfrom
xiaopengli89:config-present_with_transaction
Closed

Update present_with_transaction#3111
xiaopengli89 wants to merge 1 commit intogfx-rs:masterfrom
xiaopengli89:config-present_with_transaction

Conversation

@xiaopengli89
Copy link
Copy Markdown
Contributor

@xiaopengli89 xiaopengli89 commented Oct 15, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description
Set present_with_transaction according to PresentMode.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 15, 2022 •
edited
Loading

Codecov Report

Merging #3111 (c24d237) into master (ce08179) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3111   +/-   ##
=======================================
  Coverage   64.75%   64.75%           
=======================================
  Files          81       81           
  Lines       38711    38711           
=======================================
+ Hits        25066    25069    +3     
+ Misses      13645    13642    -3
Impacted Files Coverage Δ
wgpu-hal/src/dx12/descriptor.rs 87.56% <0.00%> (-0.50%) ⬇️
wgpu-hal/src/gles/device.rs 80.12% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwfitzgerald
Copy link
Copy Markdown
Member

cwfitzgerald commented Oct 16, 2022

I don't think this is what we actually want. Presenting with transaction is a much more intense form of synchronization which synchronizes with CoreAnimation.

@xiaopengli89
Copy link
Copy Markdown
Contributor Author

xiaopengli89 commented Oct 16, 2022 •
edited
Loading

Is there currently a way to configure wgpu to use CoreAnimation? Because I found that there is a memory leak problem here:

wgpu/wgpu-hal/src/metal/mod.rs

Line 381 in ce08179

command_buffer.present_drawable(&texture.drawable);
it is likely to be a metal driver's bug. When there is no better solution, I hope I can somehow avoid using this api.

image

@grovesNL
Copy link
Copy Markdown
Collaborator

grovesNL commented Oct 17, 2022

@xiaopengli89 does this leak happen in regular Metal Objective-C or Swift examples? It would be great to verify if this was a actually a Metal bug or if we're accidentally holding an extra reference somewhere (i.e., we have an auto release pool missing somewhere other than present_drawable)

@xiaopengli89 xiaopengli89 mentioned this pull request Oct 19, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiaopengli89 @codecov-commenter @cwfitzgerald @grovesNL