Updating TextureFormat matching specs#2954
Merged
cwfitzgerald merged 15 commits intogfx-rs:masterfrom Sep 20, 2022
gents83:Fix-web-target-clean-compilation
Merged
Updating TextureFormat matching specs#2954cwfitzgerald merged 15 commits intogfx-rs:masterfrom gents83:Fix-web-target-clean-compilation
cwfitzgerald merged 15 commits intogfx-rs:masterfrom
gents83:Fix-web-target-clean-compilation
Conversation
cwfitzgerald
requested changes
Aug 13, 2022
maxammann
approved these changes
Aug 25, 2022
Contributor
|
I'd propose to merge this as soon as possible and do the other work in a separate pr. This is breaking our CI currently. |
Contributor
Author
|
Linking Missing TextureFormats #967 |
Contributor
Author
|
Linking Texture Format Depth24unormStencil8 not exist in WebGPU #2942 |
Contributor
|
Thanks @gents83 for rocking this PR :D |
cwfitzgerald
requested changes
Aug 28, 2022
Contributor
|
A few tests seem to fail. Should DEPTH24PLUS_STENCIL8 be required by default by wgpu? |
Contributor
Author
|
It should be ok now- need just a new review from @cwfitzgerald |
Contributor
|
Workaround right now is |
Contributor
Author
|
Is there any chance to integrate this to fix the web target? |
cwfitzgerald
requested changes
Sep 19, 2022
3 tasks
Member
|
Just have formatting and a merge conflict and we're g2g |
crowlKats
reviewed
Sep 20, 2022
Collaborator
crowlKats
left a comment
There was a problem hiding this comment.
spec wise looks correct
cwfitzgerald
approved these changes
Sep 20, 2022
This was referenced Nov 9, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing compilation error - when doing a full clean:
error[E0599]: no variant or associated item named
Depth24unormStencil8found for enumGpuTextureFormatin the current scope--> D:\a\INOX\INOX\extern\wgpu\wgpu\src\backend\web.rs:553:52
|
553 | TextureFormat::Depth24UnormStencil8 => tf::Depth24unormStencil8,
| ^^^^^^^^^^^^^^^^^^^^
| |
| variant or associated item not found in
GpuTextureFormat| help: there is a variant with a similar name:
Depth24plusStencil8