Evolve depth clamping into clip control#2171
Merged
kvark merged 1 commit intogfx-rs:masterfrom Nov 10, 2021
Merged
Conversation
msiglreith
reviewed
Nov 10, 2021
msiglreith
reviewed
Nov 10, 2021
Member
Author
|
Excellent review of Vulkan code, thanks @msiglreith ! |
tychedelia
added a commit
to tychedelia/nannou
that referenced
this pull request
Oct 10, 2023
zmitchell
pushed a commit
to zmitchell/splatter
that referenced
this pull request
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Upstream gpuweb/gpuweb#2100
Reported in #2170
Description
The new semantics is subtly different. We can't portably enable/disable all clamping. The final clamp needs to happen unconditionally. But we can disable the early stage clipping. So now this requires Vulkan extension for depth clip control.
Testing
Running shadow.