Skip to content

wgpu_core::resource::Sampler::filtering is not set to true if SamplerDescriptor::mipmap_filter is Linear #5948

@jimblandy

Description

@jimblandy

According to WebGPU's steps for createSampler, a GPUSampler's [[isFiltering]] internal slot should be true if GPUSamplerDescriptor's mipMapFilter member is "linear". I believe wgpu_core::resource::Sampler::filtering is the wgpu-core analog of [[isFiltering]], but the code to initialize it reads:

            filtering: desc.min_filter == wgt::FilterMode::Linear
                || desc.mag_filter == wgt::FilterMode::Linear,

I think this should also consider desc.mipmap_filter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: validationIssues related to validation, diagnostics, and error handlingtype: bugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions