Skip to content

Do we need to call VaryingContext::validate at all when #[cfg(not(feature = "validate"))]? #4490

@jimblandy

Description

@jimblandy

If I understand correctly, when the "validate" feature is not enabled, we should only do enough work to produce a ModuleInfo the backends can use, and no more. But naga::valid::Validator::validate_entry_point calls VaryingContext::validate on the entry point's arguments and return value, and I don't see that that contributes anything to the final ModuleInfo.

Should those calls be protected by a #[cfg(not(feature = "validate"))] condition?

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: validationIssues related to validation, diagnostics, and error handlingnagaShader Translator

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions