-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feature request: disable uniformity analysis on shader creation #3135
Copy link
Copy link
Closed
Labels
area: naga processingPasses over IR in the middlePasses over IR in the middlearea: validationIssues related to validation, diagnostics, and error handlingIssues related to validation, diagnostics, and error handlinghelp requiredWe need community help to make this happen.We need community help to make this happen.nagaShader TranslatorShader Translatortype: enhancementNew feature or requestNew feature or request
Description
Uniformity analysis of WGSL is too strict and fails to accept some valid shaders, including the coarse rasterization stage of piet-gpu. This is captured in an upstream WGSL bug and mitigations are being discussed. One such mitigation is to opt-out of the analysis.
I'd like a flag to disable uniformity analysis at shader creation time. That flag already exists in the naga API as ValidationFlags, but that's currently hardcoded to all() in wgpu-core's Device::create_shader_module() method, so basically what I'm asking is for that to be plumbed through.
The feature can be a temporary stopgap, and should probably be marked as such, until the issue is resolved upstream.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area: naga processingPasses over IR in the middlePasses over IR in the middlearea: validationIssues related to validation, diagnostics, and error handlingIssues related to validation, diagnostics, and error handlinghelp requiredWe need community help to make this happen.We need community help to make this happen.nagaShader TranslatorShader Translatortype: enhancementNew feature or requestNew feature or request