This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Merged
Conversation
jimblandy
approved these changes
Aug 18, 2021
Member
jimblandy
left a comment
There was a problem hiding this comment.
Okay. This looks good overall, but I'm not sure I understand what's going on in the HLSL output. I don't understand why it needs to be so complicated. But if I've misunderstood, and it really needs to do that, then this is fine.
Member
Author
|
The output is a bit simpler now. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See gpuweb/gpuweb#1684 and gpuweb/gpuweb#944
It's mostly straightforward, except for HLSL, where it requires host API collaboration. Just like with base instance/vertex, the host API needs to provide the info in the root signature.