App Submission: Ghostfolio#396
App Submission: Ghostfolio#396nevets963 merged 5 commits intogetumbrel:masterfrom metacurb:ghostfolio
Conversation
nevets963
left a comment
There was a problem hiding this comment.
@BeauAgst Many many thanks for submitting Ghostfolio into the Umbrel App Store! Overall, this was a super clean PR 😄
I touched up a few tiny things - could you triple check those commits to make sure I haven't done anything silly?
Otherwise, I've tested this on arm64 and amd64 and it's working nicely.
This is approved from me. We only need to prepare the graphics now for the app store. I'll speak with our graphics designer and get this actioned.
|
Graphics have been created and exist here: getumbrel/umbrel-apps-gallery#37 |
|
Hey @nevets963, the only thing I would question is that we've removed 3334 from the list of exposes ports, but the docker image only exposes 3333 by default. This port is already being used by another app from what I could tell |
|
@BeauAgst It looks like the server container is set to listen on port 3334 (https://github.com/getumbrel/umbrel-apps/pull/396/files#diff-f83aef0ad7dbb18e3a44a765cda67cedf674a3bcd528ed0d8ea9d8b1c6957656R15) which the App Proxy forwards onto (via the Docker bridge). The app is also set to use port 3334 (which is what the App Proxy opens on the host). ie. in 1 case the port 3334 is opened on the container, in the other, port 3334 is opened on the host so there aren't any conflicts. |
|
Amazing! I'm not much of a Docker expert, so thanks for explaining 🙏🏼 |
|
Merged 🚀 @BeauAgst Re Markdown support, currently we don't do this incase it introduces XSS as an attack vector - but I'm sure at some point we'll be able to do something to improve the formatting of app descriptions. |
|
Thanks @BeauAgst for the Ghostfolio app submission 👍🏻 |
|
Yep 😄 It's already live in the App Store
|
Thanks for the information @nevets963 😎 |
App Submission
Closes #386
App name
Ghostfolio
256x256 SVG icon
https://svgur.com/s/q3G
Gallery images
I've not actually used the app myself, so @dtslvr may want to supply some better pictures to show it off!
I have tested my app on:
@nevets963 have you thought about supporting markdown in the app store? I think it could really help with formatting and inserting links into content 👍🏼