Add separate subcommands for encryption, decryption, rotating, editing, and setting values #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24efcbd to
4189af5
Compare
Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
4189af5 to
c3abac2
Compare
Contributor
Author
|
Now that #1389 has been merged, this is ready for review! 🎉 |
Contributor
Author
|
@hiddeco thanks a lot for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another Work in Progress for exploring how to implement #1333, similar to the original WIP #1343. Right now the new subcommands are basically a stripped-down copy'n'paste of the current "main" command. This PR based upon #1389, which reduces the copy'n'paste a lot.
Fixes #1333
This PR includes the PRs #1389 and #1390. I will rebase once these are merged.