Skip to content

Conversation

@simcax
Copy link
Contributor

@simcax simcax commented Feb 10, 2022

I have added some examples of having age recipients in the .sops.yaml as well as a little info about using it with updatekeys

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added two comments. Could you please rebase the result, and squash everything into one commit and make sure to sign off on it (for DCO)? Thanks.

@felixfontein
Copy link
Contributor

Can you please squash the commits and sign-off on the resulting commit (see https://github.com/getsops/sops/pull/1001/checks?check_run_id=16863365696)?

@simcax
Copy link
Contributor Author

simcax commented Sep 21, 2023

Can you please squash the commits and sign-off on the resulting commit (see https://github.com/getsops/sops/pull/1001/checks?check_run_id=16863365696)?

Sure thing, will do it tonight or tomorrow.

paulolieuthier and others added 6 commits September 23, 2023 08:15
* Match file path relative to config file's directory

* Update README.rst

Signed-off-by: Carsten Skov <carsten@simcax.dk>
Signed-off-by: Carsten Skov <carsten@simcax.dk>
corrected path to keys based on the real behavior. see [1]

[1]
https://github.com/mozilla/sops/blob/master/age/keysource.go#L108

Signed-off-by: Carsten Skov <carsten@simcax.dk>
Signed-off-by: Carsten Skov <carsten@simcax.dk>
…etsops#906)

* `golang.org/x/crypto/openpgp` requires keys contain identity information.
* A email address can have only a single key with identity information on keys.openpgp.org.

Signed-off-by: Carsten Skov <carsten@simcax.dk>
Fixed formatting for example of multiple age keys in .sops.yaml

Added example of using updatekeys with age

Apply suggestions from code review

Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Carsten Skov <carsten@simcax.dk>
"path"
"path/filepath"
"regexp"
"strings"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR now contains changes that should not be part of it. I guess something went wrong during rebasing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I must have messed it up. Will give it a look again - sorry about the mess @felixfontein

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, such things happen ;-) Better look at the "File changed" view on GitHub (https://github.com/getsops/sops/pull/1001/files) next time after rebasing to see whether the result looks as expected.

@felixfontein
Copy link
Contributor

Ping @simcax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants