ci: publish vroom to GHCR and provide a tagged release on GHCR#576
ci: publish vroom to GHCR and provide a tagged release on GHCR#576BYK merged 9 commits intogetsentry:mainfrom
Conversation
.github/workflows/ci.yaml
Outdated
| - timeout-minutes: 20 | ||
| run: until docker pull "us-central1-docker.pkg.dev/sentryio/vroom/vroom:${{ github.sha }}" 2>/dev/null; do sleep 10; done |
There was a problem hiding this comment.
Let's definitely not do this and move the actual build to GitHub Actions. Otherwise you are just wasting CPU cycles and holding up workers until the Google build is done.
Alternatively, you can just another target in .craft.yml which does exactly what you do here.
|
Ah, the failure was due to permissions. Retried from my account, let's see if it goes through. |
@BYK I believe it was due to this https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#pushing-container-images
|
|
Hello, can you guys take a look at this? @hubertdeng123 @asottile-sentry |
|
We need to update the image in the deploy script as well or push to both places https://github.com/getsentry/vroom/blob/main/gocd/templates/bash/deploy.sh#L8 |
I believe this PR already push to both places. |
Ah, you are indeed correct and Cloud Build is responsible for this. |
|
@mdtro Hey, can you take a look over the build CI? Seems like another permission issue. |
| uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 # v3.10.0 | ||
|
|
||
| - name: Build | ||
| uses: docker/build-push-action@32945a339266b759abcbdc89316275140b0fc960 # v6.8.10 | ||
| with: | ||
| context: . | ||
| cache-from: ghcr.io/getsentry/vroom:nightly | ||
| cache-to: type=inline |
There was a problem hiding this comment.
I feel like we are missing out on the <sha> part in the tag?
There was a problem hiding this comment.
No, that one is being handled by another job on assemble-image.
There was a problem hiding this comment.
Ignore this, I see it below now. But we should explain this flow in code comments.
Similar work with these PRs:
While also trying to provide a solution (or at least an alternative) for this issue: getsentry/self-hosted#3593
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.