Skip to content

chore: Remove uptime checks dataset, resolver and consumer#7491

Merged
phacops merged 2 commits intomasterfrom
pierre/eap-remove-uptime-checks
Oct 30, 2025
Merged

chore: Remove uptime checks dataset, resolver and consumer#7491
phacops merged 2 commits intomasterfrom
pierre/eap-remove-uptime-checks

Conversation

@phacops
Copy link
Contributor

@phacops phacops commented Oct 29, 2025

This dataset needs to be removed as it's not used by any front facing feature anymore.

@phacops phacops requested review from a team as code owners October 29, 2025 21:55
Copy link
Member

@MeredithAnya MeredithAnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phacops
Copy link
Contributor Author

phacops commented Oct 29, 2025

Actually do we need to remove uptime consumer logic from ST first? (think its still running in S4S https://github.com/getsentry/ops/blob/73d3c802f004f9a871950dc6975021a53469d091/k8s/st-services-deprecated-do-not-add-new-services/snuba/region_overrides/s4s/default.yaml#L161-L162)

Ah, good catch.

@phacops
Copy link
Contributor Author

phacops commented Oct 30, 2025

@phacops phacops requested a review from MeredithAnya October 30, 2025 00:02
@phacops phacops dismissed MeredithAnya’s stale review October 30, 2025 21:51

Addressed the comment.

@phacops phacops merged commit cfaaad9 into master Oct 30, 2025
34 checks passed
@phacops phacops deleted the pierre/eap-remove-uptime-checks branch October 30, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants