chore: Test ClickHouse 25.3 by phacops · Pull Request #7339 · getsentry/snuba

phacops · 2025-08-06T00:21:23Z

Same as before, but with replays acceptance tests.

codecov · 2025-08-06T00:27:35Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
237	1	236	6

View the top 1 failed test(s) by shortest run time

tests.clickhouse.test_native::test_concurrency_limit

Stack Traces | 0.013s run time

Traceback (most recent call last):
  File ".../local/lib/python3.11........./site-packages/_pytest/runner.py", line 341, in from_call
    result: TResult | None = func()
                             ^^^^^^
  File ".../local/lib/python3.11........./site-packages/_pytest/runner.py", line 242, in <lambda>
    lambda: runtest_hook(item=item, **kwds), when=when, reraise=reraise
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../local/lib/python3.11....../site-packages/pluggy/_hooks.py", line 513, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../local/lib/python3.11....../site-packages/pluggy/_manager.py", line 120, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 182, in _multicall
    return outcome.get_result()
           ^^^^^^^^^^^^^^^^^^^^
  File ".../local/lib/python3.11.../site-packages/pluggy/_result.py", line 100, in get_result
    raise exc.with_traceback(exc.__traceback__)
  File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall
    teardown.throw(outcome._exception)
  File ".../local/lib/python3.11....../site-packages/_pytest/threadexception.py", line 92, in pytest_runtest_call
    yield from thread_exception_runtest_hook()
  File ".../local/lib/python3.11....../site-packages/_pytest/threadexception.py", line 68, in thread_exception_runtest_hook
    yield
  File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall
    teardown.throw(outcome._exception)
  File ".../local/lib/python3.11....../site-packages/_pytest/unraisableexception.py", line 95, in pytest_runtest_call
    yield from unraisable_exception_runtest_hook()
  File ".../local/lib/python3.11....../site-packages/_pytest/unraisableexception.py", line 70, in unraisable_exception_runtest_hook
    yield
  File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall
    teardown.throw(outcome._exception)
  File ".../local/lib/python3.11....../site-packages/_pytest/logging.py", line 846, in pytest_runtest_call
    yield from self._runtest_for(item, "call")
  File ".../local/lib/python3.11....../site-packages/_pytest/logging.py", line 829, in _runtest_for
    yield
  File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall
    teardown.throw(outcome._exception)
  File ".../local/lib/python3.11.../site-packages/_pytest/capture.py", line 880, in pytest_runtest_call
    return (yield)
            ^^^^^
  File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall
    teardown.throw(outcome._exception)
  File ".../local/lib/python3.11.../site-packages/_pytest/skipping.py", line 257, in pytest_runtest_call
    return (yield)
            ^^^^^
  File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 103, in _multicall
    res = hook_impl.function(*args)
          ^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../local/lib/python3.11........./site-packages/_pytest/runner.py", line 174, in pytest_runtest_call
    item.runtest()
  File ".../local/lib/python3.11....../site-packages/_pytest/python.py", line 1627, in runtest
    self.ihook.pytest_pyfunc_call(pyfuncitem=self)
  File ".../local/lib/python3.11....../site-packages/pluggy/_hooks.py", line 513, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../local/lib/python3.11....../site-packages/pluggy/_manager.py", line 120, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 139, in _multicall
    raise exception.with_traceback(exception.__traceback__)
  File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 103, in _multicall
    res = hook_impl.function(*args)
          ^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../local/lib/python3.11....../site-packages/_pytest/python.py", line 159, in pytest_pyfunc_call
    result = testfunction(**testargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../tests/clickhouse/test_native.py", line 82, in test_concurrency_limit
    assert connection.execute.call_count == 2, "Expected two attempts"
AssertionError: Expected two attempts
assert 1 == 2
 +  where 1 = <Mock name='mock.execute' id='139691172964688'>.call_count
 +    where <Mock name='mock.execute' id='139691172964688'> = <Mock id='139691172988112'>.execute

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

onkar

LGTM, added a question.

onkar · 2025-08-13T15:43:42Z

devservices/config.yml

 services:
  clickhouse:
-    image: ghcr.io/getsentry/image-mirror-altinity-clickhouse-server:23.8.11.29.altinitystable
+    image: ghcr.io/getsentry/image-mirror-altinity-clickhouse-server:25.3.6.10034.altinitystable


We usually go from 23.8 -> 24.3 -> 24.8 -> 25.3 in production, whereas here we are jumping directly to 25.3. I understand that this is for local but will it cause any issues?

It won't. There's no format change to what's on disk between those versions and there's no network protocol change that needs to be considered since it's a single node.

phacops added 16 commits August 1, 2025 15:52

chore: Test ClickHouse 25.3

08fcaa5

Add the new version to the test matrix

19e8e57

Default to new version for tests

440394b

Add missing users.xml config file

97a24a1

Wrong path for config

30358a6

Force no password

aa044e7

Force no default user

4ee2710

Ship an empty default password file

e3b8648

Better XML

cf05b51

Revert some unneeded changes

1929d7b

Fix version number

5990d9e

Remove unneeded version from matrix

b7a5c96

Revert setting to the default

1838002

Let's not remove the default section

1190b1c

Override default-password for devservices as well

e015298

Test more things

6f8a4b9

phacops requested a review from a team as a code owner August 6, 2025 00:21

phacops changed the title ~~Pierre/test clickhouse 25.3 3~~ Pierre/test clickhouse 25.3 Aug 6, 2025

phacops changed the title ~~Pierre/test clickhouse 25.3~~ chore: Test ClickHouse 25.3 Aug 6, 2025

Run Sentry tests

f049585

phacops mentioned this pull request Aug 8, 2025

fix(replays): Remove one too many of the same aliases getsentry/sentry#97540

Merged

phacops added 4 commits August 8, 2025 17:30

Merge branch 'master' into pierre/test-clickhouse-25.3-3

d623bb8

Merge branch 'master' into pierre/test-clickhouse-25.3-3

fa23f71

Merge branch 'master' into pierre/test-clickhouse-25.3-3

df0f114

Revert to run tests only when there are API changes

e156d67

onkar approved these changes Aug 13, 2025

View reviewed changes

phacops merged commit e808038 into master Aug 13, 2025
35 checks passed

phacops deleted the pierre/test-clickhouse-25.3-3 branch August 13, 2025 17:45

aldy505 mentioned this pull request Aug 16, 2025

chore(deps): bump clickhouse to 25.3 getsentry/self-hosted#3878

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Test ClickHouse 25.3#7339

chore: Test ClickHouse 25.3#7339
phacops merged 21 commits intomasterfrom
pierre/test-clickhouse-25.3-3

phacops commented Aug 6, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 6, 2025 •

edited

Loading

Uh oh!

onkar left a comment

Uh oh!

onkar Aug 13, 2025

Uh oh!

phacops Aug 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

phacops commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

onkar left a comment

Choose a reason for hiding this comment

Uh oh!

onkar Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

phacops Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

phacops commented Aug 6, 2025 •

edited

Loading

codecov bot commented Aug 6, 2025 •

edited

Loading