feat(outcomes): Add additional discard reasons#3694
Merged
Conversation
nikhars
approved these changes
Feb 2, 2023
Member
Not in Snuba. I can't speak to ingest etc.
There are tests in this file: https://github.com/getsentry/snuba/blob/master/tests/test_outcomes_api.py |
Member
Author
|
@evanh Sounds good. Just wanted to be sure this was a low cardinality field and not an enum which would have required a migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getsentry/sentry-javascript#6774
Adds two new discard reasons to support replays javascript sdk use-cases. More information can be found in the linked issue.