Skip to content

Conversation

@mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented Sep 5, 2021

This adds a new outcome type 5 which is reserved for recording events discarded on the client side.

Refs getsentry/relay#1074

@mitsuhiko mitsuhiko requested a review from a team as a code owner September 5, 2021 07:59
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2021

Codecov Report

Merging #2081 (2e78965) into master (bfabb58) will increase coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2081      +/-   ##
==========================================
+ Coverage   91.14%   91.21%   +0.06%     
==========================================
  Files         510      510              
  Lines       22191    22198       +7     
==========================================
+ Hits        20227    20247      +20     
+ Misses       1964     1951      -13     
Impacted Files Coverage Δ
snuba/datasets/outcomes_processor.py 92.59% <75.00%> (-7.41%) ⬇️
snuba/cli/bootstrap.py 10.34% <0.00%> (+10.34%) ⬆️
snuba/cli/api.py 43.47% <0.00%> (+26.08%) ⬆️
snuba/cli/__init__.py 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfabb58...2e78965. Read the comment docs.

@fpacifici
Copy link
Contributor

Some context on the volume we expect.
Do we have an idea of how many events are discarded by the sdk per second? Impact:

  • we may need a bigger clickhouse cluster (it is possible but it takes time and needs some planning)
  • The consumer is already spread fairly thin (8 replicas). We have work too do to make consumption of high volumes of small events more efficient.

@mitsuhiko
Copy link
Contributor Author

@fpacifici i will do some estimates on this. I think we should try to merge this PR so that in case new outcomes come our way we gain the validation of the values.

@mitsuhiko mitsuhiko merged commit a0d1521 into master Sep 10, 2021
@mitsuhiko mitsuhiko deleted the feature/client-reports branch September 10, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants