feat(hackweek) Remove merged jsonschema and validate it is downloaded properly. #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbennett-sentry
approved these changes
Aug 6, 2020
Makefile
Outdated
| install-python-dependencies: | ||
| pip install -e . | ||
|
|
||
| fetchschemas: |
Contributor
There was a problem hiding this comment.
Since this is now doing more than fetching -- and the fetching is really now serves secondary purpose -- should we rename it to "typecheck" or "mypy"?
Contributor
Author
There was a problem hiding this comment.
This is not really meant to typecheck. It does not show the output and it does not stop in case of conventional type errors. It runs mypy only to ensure the schema is there and intact and that the processor references the right file. If the file is missing or in the wrong place mypy fatals, exit status 2, while conventional type errors are status 1. We fail only if mypy exit status is greater than 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the jsonschema initially committed since we download the schema during
make developand avoid accidentally merge the schema downloaded during make.Also runs mypy right after downloading the schema. If the schema is not there, malformed or in the wrong place mypy fails with code 2. Then make will fail instead of silently be ok until we run it later.