Skip to content

fix(sveltekit): sentry example page should be at /sentry-example-page for consistency#973

Merged
shellmayr merged 3 commits intomasterfrom
shellmayr/fix/sentry-example-page-url
Apr 22, 2025
Merged

fix(sveltekit): sentry example page should be at /sentry-example-page for consistency#973
shellmayr merged 3 commits intomasterfrom
shellmayr/fix/sentry-example-page-url

Conversation

@shellmayr
Copy link
Copy Markdown
Member

@shellmayr shellmayr commented Apr 22, 2025

  • This aligns with the location of the page in other frameworks (consistency)
  • Our onboarding tells you that the page is located at sentry-example-page as well:
Screenshot 2025-04-22 at 14 35 53

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 24.28%. Comparing base (1a3a649) to head (e9968fc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/sveltekit/sveltekit-wizard.ts 0.00% 2 Missing ⚠️
src/sveltekit/sdk-example.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #973   +/-   ##
=======================================
  Coverage   24.28%   24.28%           
=======================================
  Files         121      121           
  Lines       12883    12883           
  Branches      715      715           
=======================================
  Hits         3128     3128           
  Misses       9734     9734           
  Partials       21       21
Flag Coverage Δ
unit-tests 24.28% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Lms24
Lms24 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I was loosely aware of this inconsistency with other wizards but never bothered to change it. Didn't know that it also was inconsistent with docs, so changing it makes a lot of sense. Thanks!

@shellmayr shellmayr marked this pull request as ready for review April 22, 2025 12:41
@shellmayr shellmayr merged commit 09b6ce3 into master Apr 22, 2025
39 of 40 checks passed
@shellmayr shellmayr deleted the shellmayr/fix/sentry-example-page-url branch April 22, 2025 12:54
@Lms24 Lms24 mentioned this pull request Apr 25, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shellmayr @Lms24