This repository was archived by the owner on Nov 20, 2023. It is now read-only.
fix(deps): Add webpack-sources dependency#397
Merged
lobsterkatie merged 2 commits intomasterfrom Oct 6, 2022
Merged
Conversation
Lms24
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #307, a dependency on
webpack-sourceswas added to the code, but not topackage.json. From that PR description:Though this logic is generally sound, it (specifically the "their webpack version is at least 5 and webpack-sources come with it" part) doesn't account for cases in which webpack is being consumed from a single bundle. In those cases, the code from
webpack-sourcesexists in the user's dev environment, but the actualwebpack-sourcespackage doesn't. (This is true, for example, in nextjs, which pre-compiles many of its dependencies, including webpack, into minified bundles.) This can lead to errors when trying to use module federation alongside our nextjs SDK.To fix this,
webpack-sourceshas been added as a first-class runtime dependency. Because that guarantees that it will be present andrequire-able, its import has been moved out of a mid-filetry-catchto instead be a legit import at the top of the file in which it's used.