Skip to content

Add crashpad_wer.dll to CMake install#818

Closed
nwhite-riot wants to merge 7 commits intomainfrom
crashpad-wer
Closed

Add crashpad_wer.dll to CMake install#818
nwhite-riot wants to merge 7 commits intomainfrom
crashpad-wer

Conversation

@nwhite-riot
Copy link
Collaborator

Fixes #815

@nwhite-riot nwhite-riot marked this pull request as ready for review March 9, 2025 17:44
@nwhite-riot nwhite-riot requested a review from tustanivsky as a code owner March 9, 2025 17:44
bitsandfoxes
bitsandfoxes previously approved these changes Mar 10, 2025
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

tustanivsky

This comment was marked as outdated.

}

$packages = Get-ChildItem "$projectRoot/sentry-unreal-*-$publishingPlatform.zip"
# TODO: Extract this functionality to share between `test-contents.ps1` and `pack.ps1`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tustanivsky
Copy link
Collaborator

Closing this PR in favor of #828 which expands on the same issue.

@nwhite-riot nwhite-riot deleted the crashpad-wer branch March 14, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crashpad_wer.dll is not installed during CMake for GitHub release

3 participants