Fix crash when re-initializing Sentry#594
Merged
tustanivsky merged 3 commits intomainfrom Jul 9, 2024
Merged
Conversation
bitsandfoxes
reviewed
Jul 9, 2024
Comment on lines
+181
to
+184
| if(OnEnsureDelegate.IsValid()) | ||
| { | ||
| FCoreDelegates::OnHandleSystemEnsure.Remove(OnEnsureDelegate); | ||
| OnEnsureDelegate.Reset(); |
Contributor
There was a problem hiding this comment.
Should this go into the closure above as well?
Collaborator
Author
There was a problem hiding this comment.
No, in order to capture ensures we don't use any of our custom output devices but rather rely on the engine's FCoreDelegates::OnHandleSystemEnsure delegate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the internal plugin crash when re-initializing
USentrySubsystemwithout its explicit closing beforehand.The crash was related to custom Sentry output devices that were not deregistered properly upon any subsequent initialization attempt.
Also, assertion/ensure delegates are now deregistered too whenever calling subsystem's
Closemethod to avoid potential reporting of the same event multiple times if re-init occured.Closes #592