Add consent-aware offline caching#1341
Merged
Merged
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
|
# Conflicts: # CHANGELOG.md
jpnurmi
approved these changes
Apr 28, 2026
| sentry_options_set_logs_with_attributes(options, true); | ||
| sentry_options_set_enable_metrics(options, settings->EnableMetrics); | ||
| sentry_options_set_before_send_metric(options, HandleBeforeMetric, this); | ||
| sentry_options_set_http_retry(options, 1); |
Collaborator
There was a problem hiding this comment.
Makes perfect sense because this brings the Native platforms on par with the Android and Cocoa siblings that have unconfigurable retries. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables HTTP retries unconditionally during SDK initialization on all sentry-native platforms where HTTP transport is used
It is required for consent-aware offline caching (getsentry/sentry-native#1542) - when consent is revoked and offline caching is enabled, envelopes are cached to disk. Once consent is granted again, triggers the retry system to immediately flush cached envelopes.
Closes #1103
Depends on: