feat(log): support combined LogFilters and RecordMappings#914
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
==========================================
+ Coverage 73.46% 73.50% +0.03%
==========================================
Files 64 64
Lines 7518 7533 +15
==========================================
+ Hits 5523 5537 +14
- Misses 1995 1996 +1 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks good in principle, but I have a suggestion for simplifying the code
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Swatinem
left a comment
There was a problem hiding this comment.
One weird thing might be that with bitflags, you can combine Ignore with any of the others just fine, and the compiler won’t complain, even though it does not make sense.
But thats a minor papercut, not worth wasting time over.
Description
Adds support for combining multiple
LogFilterswhen using our integration for thelogcrate.This way, it's possible to map a
logrecord to multiple items in Sentry, for example to both alogand anevent.This is required for #909.
There, we want to enable logs for records at or above INFO by default, in order to remove the double opt-in, while still sending breadcrumbs for them at the same time.
The changes are analogous with the ones we did for the
tracingintegration here: #847Issues
Close #908
Close RUST-111