Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 73.14% 73.13% -0.01%
==========================================
Files 64 64
Lines 7365 7366 +1
==========================================
Hits 5387 5387
- Misses 1978 1979 +1 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Nice! Just a few questions:
- How is this new type supposed to be used? Does not look like we are using it in the SDK, is it something that users are just supposed to know how to set? Or, does the
into_context!stuff take care of setting it? - Do we anticipate ever needing to add more fields to this struct?
I'll make a PR on top of this to use this in the Actix Web integration. |
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Lgtm, maybe you could add an example to the changelog, though!
Adds the
Reponsecontext, which can be attached to events.The implementation is adapted directly from the one in Relay, minus the
inferred_content_type, which as documented here can technically be sent by SDKs but will always be overridden by Relay.Part of #873