feat(types): add setters for envelope headers#868
Merged
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #868 +/- ##
==========================================
- Coverage 73.04% 72.67% -0.37%
==========================================
Files 64 64
Lines 7256 7341 +85
==========================================
+ Hits 5300 5335 +35
- Misses 1956 2006 +50 🚀 New features to boost your workflow:
|
8d9b972 to
2c94b08
Compare
szokeasaurusrex
requested changes
Jul 28, 2025
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Requesting changes, I noticed the sample_rand serialization logic could result in rounding up. Also left some lower-prio and optional comments
lcian
commented
Jul 28, 2025
szokeasaurusrex
approved these changes
Jul 28, 2025
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
lgtm, thanks for addressing comments! Left a couple more small ones to address before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies visibility where needed, and setters for envelope headers and the DSC (trace header).
Even though these are part of the public API, they are mostly going to be used internally, so I think this level of documentation is fine, especially considering we already have good docs on the structs themselves.
Stacked on: #867
Required for: #865