Skip to content

feat(logs): send logs in batches#831

Merged
lcian merged 8 commits intomasterfrom
lcian/feat/logs-batching-clean
Jun 10, 2025
Merged

feat(logs): send logs in batches#831
lcian merged 8 commits intomasterfrom
lcian/feat/logs-batching-clean

Conversation

@lcian
Copy link
Copy Markdown
Member

@lcian lcian commented Jun 6, 2025 •
edited
Loading

Implements a batcher for logs.

  • The implementation is basically the same as the one for the SessionFlusher, with different thresholds.
  • As an optimization, we don't even create the batcher if enable_logs is false.
  • The flushing is implemented as per the spec initial suggestion of flushing every 100 items or 5 seconds. We could also use different thresholds though.
  • In the future we are going to change this implementation to use the batch processor approach, which will allow us to batch logs, spans (for span streaming) and possibly other telemetry data.

@getsentry getsentry deleted a comment from github-actions bot Jun 6, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.45946% with 23 lines in your changes missing coverage. Please review.

Project coverage is 72.84%. Comparing base (5912203) to head (87c9b54).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   72.62%   72.84%   +0.21%     
==========================================
  Files          63       64       +1     
  Lines        7597     7732     +135     
==========================================
+ Hits         5517     5632     +115     
- Misses       2080     2100      +20
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lcian lcian marked this pull request as ready for review June 6, 2025 09:41
@lcian lcian requested a review from Swatinem June 6, 2025 09:41
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 87c9b54

@lcian lcian linked an issue Jun 6, 2025 that may be closed by this pull request
[Structured logging] Log batching #825
Closed
Swatinem
Swatinem approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good.

we are going to change this implementation to use the batch processor approach

Looking forward to this. would this mean that we end up with only one background thread (or maybe two if we count the transport thread)?

@lcian
Copy link
Copy Markdown
Member Author

lcian commented Jun 10, 2025

nice, looks good.

we are going to change this implementation to use the batch processor approach

Looking forward to this. would this mean that we end up with only one background thread (or maybe two if we count the transport thread)?

Yeah, exactly. At least for logs and spans, but I don't see why we wouldn't use it for sessions as well.

@lcian lcian merged commit cb7fc81 into master Jun 10, 2025
18 checks passed
@lcian lcian deleted the lcian/feat/logs-batching-clean branch June 10, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Swatinem Swatinem Swatinem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Structured logging] Log batching

2 participants

@lcian @Swatinem