Conversation
Swatinem
approved these changes
Apr 10, 2025
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
nice! I remember this was holding back some dependency updates. might be good to revisit those either here, or in a followup PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Surf transport and feature flag.
Surf is unmaintained (last commit 3 years ago). It depends on
http-clientwhich in turn drags inlexical-core<1.0.0 which is associated with this dependabot alert https://github.com/getsentry/sentry-rust/security/dependabot/11.People will still be able to use Surf if they really want to by providing their own transport factory.