fix(anyhow): attach stacktrace only if anyhow error has backtrace#759
Merged
fix(anyhow): attach stacktrace only if anyhow error has backtrace#759
Conversation
Swatinem
approved these changes
Mar 27, 2025
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
nice! thanks for fixing this and providing a good explanation.
Maybe it might be worth still checking exc.stacktrace if its empty, and clearing it in that case?
Member
Author
|
Sorry the stacktrace is not empty, it's going to have a single frame which will contain either |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to #755 but for the anyhow integration
Without this change, if we're running without
RUST_BACKTRACEset, thenbacktracewill have value"<disabled>".We would try to parse it and get an empty vec as a result.
The consequence is that all anyhows would be grouped in a single issue due to having the same (empty) stack trace.
After the change, there will be no stack trace, so grouping will happen according to the error message.
Side effect: when running with
attach_stacktrace: true,sentry-backtracewill kick in and provide a backtrace (this didn't happen before because we had a stack trace, even though it was an empty one).It could be argued whether we want this or not.
Closes #745