Replace ancient lazy_static crate with once_cell or const slices#471
Merged
Swatinem merged 1 commit intogetsentry:masterfrom Jun 13, 2022
Merged
Replace ancient lazy_static crate with once_cell or const slices#471Swatinem merged 1 commit intogetsentry:masterfrom
lazy_static crate with once_cell or const slices#471Swatinem merged 1 commit intogetsentry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
+ Coverage 80.53% 80.69% +0.16%
==========================================
Files 73 74 +1
Lines 8475 8549 +74
==========================================
+ Hits 6825 6899 +74
Misses 1650 1650 |
Piggybacking on the [motivation in winit]: `lazy_static!` is a macro whereas `once_cell` achieves the same using generics. Its implementation has also been [proposed for inclusion in `std`], making it easier to switch to a standardized version if/when that happens. The author of that winit PR is making this change to many more crates, slowly turning the scales in favour of `once_cell` in most dependency trees. Furthermore `lazy_static` hasn't published any updates for 3 years. See also [the `once_cell` F.A.Q.]. In addition "constant" `Vec`tor allocations don't need to be wrapped in a `lazy_static!` macro call at all but can be replaced with true `const` slices (or `const` sized arrays, but those are slightly more tedious to construct). [motivation in winit]: rust-windowing/winit#2313 [proposed for inclusion in `std`]: rust-lang/rust#74465 [the `once_cell` F.A.Q.]: https://docs.rs/once_cell/latest/once_cell/#faq
Swatinem
approved these changes
Jun 13, 2022
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
lgtm, thanks!
I have been following this for quite a while, but rather waiting for it to stabilize in std.
| "anyhow::", | ||
| "log::", | ||
| ]; | ||
| const WELL_KNOWN_SYS_MODULES: &[&str] = &[ |
Contributor
There was a problem hiding this comment.
nice! this could have been done independently anyway. No reason for these being Vecs
Contributor
Author
Yeah, not sure when it lands but this brings us a step closer at least :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Piggybacking on the motivation in winit:
lazy_static!is a macro whereasonce_cellachieves the same using generics. Its implementation has also been proposed for inclusion instd, making it easier to switch to a standardized version if/when that happens. The author of that winit PR is making this change to many more crates, slowly turning the scales in favour ofonce_cellin most dependency trees. Furthermorelazy_statichasn't published any updates for 3 years.See also the
once_cellF.A.Q..In addition "constant"
Vector allocations don't need to be wrapped in alazy_static!macro call at all but can be replaced with trueconstslices (orconstsized arrays, but those are slightly more tedious to construct).