Replace unnecessary shell exec to get Ruby version info#945
Closed
jsjohnst wants to merge 1 commit intogetsentry:masterfrom
Closed
Replace unnecessary shell exec to get Ruby version info#945jsjohnst wants to merge 1 commit intogetsentry:masterfrom
jsjohnst wants to merge 1 commit intogetsentry:masterfrom
Conversation
In issue getsentry#943 sub-point getsentry#2, it was identified that using RUBY_DESCRIPTION returns the same thing as `ruby -v` does for all currently supported Ruby versions. This change fixes that sub-point and provides a fallback to the old method in the event as a safety precaution.
Author
|
None of the build failures were related to my change. :| |
Contributor
|
Thanks for the fix! Can you rebase it against the latest master? I have fixed the build. |
Contributor
|
Close because of #1017 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In issue #943 sub-point #2, it was identified that using RUBY_DESCRIPTION returns the same thing as
ruby -vdoes for all currently supported Ruby versions. This change fixes that sub-point and provides a fallback to the old method in the event it fails as a safety precaution.