fix: prevent SDK crash when SDK logging fails #2817
Merged
Conversation
custom SDK loggers can crash the SDK, we guard against that by returning the exception to stderr
which might still contain e.g. encoding errors
& simplify test case from GitHub issue #2805
io errors, re-assigment
dingsdax
commented
Jan 5, 2026
|
|
||
| # @!visibility private | ||
| def log_to_stderr(error, message) | ||
| $stderr.puts("Sentry SDK logging failed (#{error.class}: #{error.message}): #{message}".scrub(%q(<?>))) |
Contributor
Author
There was a problem hiding this comment.
🤔 output stacktrace maybe too?
Collaborator
There was a problem hiding this comment.
@dingsdax yes I think that would be very helpful
solnic
approved these changes
Jan 5, 2026
|
|
||
| # @!visibility private | ||
| def log_to_stderr(error, message) | ||
| $stderr.puts("Sentry SDK logging failed (#{error.class}: #{error.message}): #{message}".scrub(%q(<?>))) |
Collaborator
There was a problem hiding this comment.
@dingsdax yes I think that would be very helpful
sl0thentr0py
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error handling to LoggingHelper methods to fallback to stderr when SDK loggers fail (e.g., JSON formatters with invalid UTF-8 in custom SDK logger). Prevents SDK from crashing while maintaining error visibility.